flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8468) Make the connector to take advantage of AMQP features (routing key, exchange and message properties)
Date Tue, 05 Jun 2018 15:58:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501993#comment-16501993
] 

ASF GitHub Bot commented on FLINK-8468:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5410#discussion_r193119522
  
    --- Diff: flink-connectors/flink-connector-rabbitmq/README.md ---
    @@ -9,3 +9,7 @@ nor packages binaries from the "RabbitMQ AMQP Java Client".
     Users that create and publish derivative work based on Flink's
     RabbitMQ connector (thereby re-distributing the "RabbitMQ AMQP Java Client")
     must be aware that this may be subject to conditions declared in the Mozilla Public License
1.1 ("MPL"), the GNU General Public License version 2 ("GPL") and the Apache License version
2 ("ASL").
    +
    +# This version provides a mechanism to handle AMQ Messaging features
    --- End diff --
    
    I think the Javadocs of the constructors are in better shape  than the contents of the
`README.md`. I think we can drop this paragraph for now. What do you think?


> Make the connector to take advantage of AMQP features (routing key, exchange and message
properties)
> ----------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-8468
>                 URL: https://issues.apache.org/jira/browse/FLINK-8468
>             Project: Flink
>          Issue Type: Improvement
>          Components: RabbitMQ Connector
>    Affects Versions: 1.4.0
>            Reporter: Ph.Duveau
>            Priority: Major
>
> Make the connector to take advantage of AMQP features by adding a constructor and an
interface to implement



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message