flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3952) Bump Netty to 4.1
Date Tue, 12 Jun 2018 14:54:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509715#comment-16509715
] 

ASF GitHub Bot commented on FLINK-3952:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6071#discussion_r194770093
  
    --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/ChunkedByteBuf.java
---
    @@ -88,6 +102,16 @@ public ByteBuf readChunk(ChannelHandlerContext ctx) throws Exception
{
     		}
     	}
     
    +	@Override
    +	public long length() {
    +		return length;
    +	}
    +
    +	@Override
    +	public long progress() {
    +		return length - buf.readableBytes();
    --- End diff --
    
    changed to `return buf.readerIndex()` since progress is not well defined.


> Bump Netty to 4.1
> -----------------
>
>                 Key: FLINK-3952
>                 URL: https://issues.apache.org/jira/browse/FLINK-3952
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core, Network
>            Reporter: rektide de la fey
>            Assignee: Piotr Nowojski
>            Priority: Major
>              Labels: netty
>
> Netty 4.1 is about to release final. This release has [a number of significant enhancements|http://netty.io/wiki/new-and-noteworthy-in-4.1.html],
and in particular I find HTTP/2 codecs to be incredibly desirable to have. 
> Additionally, hopefully, the [Hadoop patches for Netty 4.1|https://issues.apache.org/jira/browse/HADOOP-11716]
get some tests and get merged, & I believe if/when that happens it'll be important for
Flink to also be using the new Netty minor version.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message