flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi
Date Fri, 29 Jun 2018 15:08:20 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6188#discussion_r199190279
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
    @@ -1029,6 +1029,29 @@ object temporalOverlaps {
         TemporalOverlaps(leftTimePoint, leftTemporal, rightTimePoint, rightTemporal)
       }
     }
    +/**
    +  * Adds a (signed) integer interval to a timestamp. The unit for the interval is given
    +  * by the unit argument, which should be one of the following values: "SECOND", "MINUTE",
    +  * "HOUR", "DAY", "WEEK", "MONTH", "QUARTER" or "YEAR".
    +  *
    +  * e.g. timestampAdd("WEEK", 1, '2003-01-02'.toDate) leads to "2003-01-09".
    +  */
    +object timestampAdd {
    +
    +  /**
    +    * Adds a (signed) integer interval to a timestamp. The unit for the interval is given
    +    * by the unit argument, which should be one of the following values: "SECOND", "MINUTE",
    +    * "HOUR", "DAY", "WEEK", "MONTH", "QUARTER" or "YEAR".
    +    *
    +    * e.g. timestampAdd("WEEK", 1, '2003-01-02'.toDate) leads to "2003-01-09".
    +  */
    +  def apply(
    +      unit: Expression,
    --- End diff --
    
    I think we can and should add `week`. 
    
    `quarter` is a bit more tricky... IMO, the current method is not well aligned with the
other methods (`hour`, `day`, etc.) and it would make sense to change it for better consistency.
However, such as change would break the API. What do you think @twalthr?


---

Mime
View raw message