flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #6201: [FLINK-8866][Table API & SQL] Add support for unif...
Date Tue, 26 Jun 2018 17:19:46 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6201#discussion_r198137230
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/connector/TableConnectorFactoryService.scala
---
    @@ -16,57 +16,57 @@
      * limitations under the License.
      */
     
    -package org.apache.flink.table.sources
    +package org.apache.flink.table.connector
     
     import java.util.{ServiceConfigurationError, ServiceLoader}
     
    -import org.apache.flink.table.api.{AmbiguousTableSourceException, NoMatchingTableSourceException,
TableException, ValidationException}
    -import org.apache.flink.table.descriptors.ConnectorDescriptorValidator.CONNECTOR_PROPERTY_VERSION
    -import org.apache.flink.table.descriptors.FormatDescriptorValidator.FORMAT_PROPERTY_VERSION
    -import org.apache.flink.table.descriptors.MetadataValidator.METADATA_PROPERTY_VERSION
    -import org.apache.flink.table.descriptors.StatisticsValidator.STATISTICS_PROPERTY_VERSION
    -import org.apache.flink.table.descriptors._
    +import org.apache.flink.table.api._
    +import org.apache.flink.table.descriptors.ConnectorDescriptorValidator._
    +import org.apache.flink.table.descriptors.FormatDescriptorValidator._
    +import org.apache.flink.table.descriptors.MetadataValidator._
    +import org.apache.flink.table.descriptors.StatisticsValidator._
    +import org.apache.flink.table.descriptors.{DescriptorProperties, TableDescriptor, TableDescriptorValidator}
    +import org.apache.flink.table.sinks.TableSink
    +import org.apache.flink.table.sources.TableSource
     import org.apache.flink.table.util.Logging
     
    -import scala.collection.JavaConverters._
    -import scala.collection.mutable
    +import _root_.scala.collection.JavaConverters._
    +import _root_.scala.collection.mutable
     
     /**
    -  * Service provider interface for finding suitable table source factories for the given
properties.
    +  * Unified interface to create TableConnectors, e.g. [[org.apache.flink.table.sources.TableSource]]
    +  * and [[org.apache.flink.table.sinks.TableSink]].
       */
    -object TableSourceFactoryService extends Logging {
    +class TableConnectorFactoryService[T] extends Logging {
     
    -  private lazy val defaultLoader = ServiceLoader.load(classOf[TableSourceFactory[_]])
    +  private lazy val defaultLoader = ServiceLoader.load(classOf[TableConnectorFactory[_]])
     
    -  def findAndCreateTableSource(descriptor: TableSourceDescriptor): TableSource[_] = {
    -    findAndCreateTableSource(descriptor, null)
    +  def findAndCreateTableConnector(descriptor: TableDescriptor): T = {
    +    findAndCreateTableConnector(descriptor, null)
       }
     
    -  def findAndCreateTableSource(
    -      descriptor: TableSourceDescriptor,
    -      classLoader: ClassLoader)
    -    : TableSource[_] = {
    +  def findAndCreateTableConnector(descriptor: TableDescriptor, classLoader: ClassLoader)
    --- End diff --
    
    This can fit into one line.


---

Mime
View raw message