flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #6199: [FLINK-9624][runtime] Move jar/artifact upload out...
Date Mon, 25 Jun 2018 08:52:07 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6199#discussion_r197721680
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java
---
    @@ -114,17 +114,12 @@ public JarRunHandler(
     
     		CompletableFuture<JobGraph> jarUploadFuture = jobGraphFuture.thenCombine(blobServerPortFuture,
(jobGraph, blobServerPort) -> {
     			final InetSocketAddress address = new InetSocketAddress(getDispatcherHost(gateway),
blobServerPort);
    -			final List<PermanentBlobKey> keys;
    -			try {
    -				keys = BlobClient.uploadFiles(address, configuration, jobGraph.getJobID(), jobGraph.getUserJars());
    +			try (BlobClient blobClient = new BlobClient(address, configuration)) {
    +				ClientUtils.uploadAndSetUserJars(jobGraph, blobClient);
    --- End diff --
    
    we _could_ use `uploadJobGraphFiles` here, but there isn't really a use-case for uploading
distributed cache artifacts when going through the JarRunHandler, since we're already on the
server here.


---

Mime
View raw message