flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dawidwys <...@git.apache.org>
Subject [GitHub] flink pull request #5448: [FLINK-6469] Configure Memory Sizes with units
Date Mon, 25 Jun 2018 08:15:56 GMT
Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5448#discussion_r197707216
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterSpecification.java
---
    @@ -67,8 +68,8 @@ public String toString() {
     	public static ClusterSpecification fromConfiguration(Configuration configuration) {
     		int slots = configuration.getInteger(TaskManagerOptions.NUM_TASK_SLOTS, 1);
     
    -		int jobManagerMemoryMb = configuration.getInteger(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY);
    -		int taskManagerMemoryMb = configuration.getInteger(TaskManagerOptions.TASK_MANAGER_HEAP_MEMORY);
    +		int jobManagerMemoryMb = (int) MemorySize.parse(configuration.getString(JobManagerOptions.JOB_MANAGER_HEAP_MEMORY)).getMebiBytes();
    --- End diff --
    
    use `getMebiBytesAsInt`


---

Mime
View raw message