flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #6180: [FLINK-9524][Table API & SQL] check whether a clea...
Date Fri, 22 Jun 2018 14:17:12 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6180#discussion_r197453796
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedRangeOver.scala
---
    @@ -132,74 +132,80 @@ class ProcTimeBoundedRangeOver(
     
         val currentTime = timestamp - 1
         var i = 0
    +    // get the list of elements of current proctime
    +    val currentElements = rowMapState.get(currentTime)
     
    -    // initialize the accumulators
    -    var accumulators = accumulatorState.value()
    +    // clean-up timers might expire, which pass the needToCleanupState check above.
    --- End diff --
    
    Please rephrase comment to 
    ```
    // Expired clean-up timers pass the needToCleanupState() check. 
    // Perform a null check to verify that we have data to process.
    ```


---

Mime
View raw message