flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #6189: [FLINK-9599][rest] RestClient supports FileUploads...
Date Thu, 21 Jun 2018 13:46:22 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6189#discussion_r197138450
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java
---
    @@ -106,7 +106,7 @@ protected void channelRead0(final ChannelHandlerContext ctx, final
HttpObject ms
     				final HttpContent httpContent = (HttpContent) msg;
     				currentHttpPostRequestDecoder.offer(httpContent);
     
    -				while (currentHttpPostRequestDecoder.hasNext()) {
    +				while (httpContent != LastHttpContent.EMPTY_LAST_CONTENT && currentHttpPostRequestDecoder.hasNext())
{
    --- End diff --
    
    But we are using the `HttpPostRequestEncoder`, right? So do we use it maybe wrongly?


---

Mime
View raw message