flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #6189: [FLINK-9599][rest] RestClient supports FileUploads...
Date Thu, 21 Jun 2018 09:47:52 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6189#discussion_r197069842
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java ---
    @@ -212,6 +271,86 @@ public void shutdown(Time timeout) {
     				executor);
     	}
     
    +	private interface RequestProcessor<T> {
    +		T createRequest(HttpRequest request, ByteBuf jsonPayload) throws IOException;
    +
    +		void writeRequest(T body, Channel channel) throws IOException;
    +	}
    +
    +	private static final class DefaultProcessor implements RequestProcessor<HttpRequest>
{
    --- End diff --
    
    Rename to `SimpleRequest` which is initialized with a `HttpRequest` which it writes out
in the writeRequest method.


---

Mime
View raw message