flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aitozi <...@git.apache.org>
Subject [GitHub] flink pull request #6168: [FLINK-9588][CEP]Reused context with same computat...
Date Fri, 15 Jun 2018 16:14:29 GMT
Github user Aitozi commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6168#discussion_r195792448
  
    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
    @@ -609,7 +611,7 @@ public void close() throws Exception {
     							startTimestamp);
     
     					//check if newly created state is optional (have a PROCEED path to Final state)
    -					final State<T> finalState = findFinalStateAfterProceed(sharedBuffer, nextState,
event.getEvent(), computationState);
    +					final State<T> finalState = findFinalStateAfterProceed(new ConditionContext<>(this,
sharedBuffer, computationState), nextState, event.getEvent());
    --- End diff --
    
    I think over it again, the content of the `sharedBuffer` make difference  to  the result
of the `getEventsForPattern`, so the result should be update with the change of the `sharedBuffer`.
But i think we only have to reset the `shouldUpdate` flag to `true` here rather than create
a  context again, right? @dawidwys 


---

Mime
View raw message