flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #5857: [FLINK-9187][METRICS] add prometheus pushgateway r...
Date Fri, 15 Jun 2018 07:18:02 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5857#discussion_r195650428
  
    --- Diff: flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
    @@ -0,0 +1,79 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.metrics.prometheus;
    +
    +import org.apache.flink.annotation.PublicEvolving;
    +import org.apache.flink.metrics.Metric;
    +import org.apache.flink.metrics.MetricConfig;
    +import org.apache.flink.metrics.reporter.MetricReporter;
    +import org.apache.flink.metrics.reporter.Scheduled;
    +import org.apache.flink.util.AbstractID;
    +
    +import io.prometheus.client.CollectorRegistry;
    +import io.prometheus.client.exporter.PushGateway;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +/**
    + * /**
    + * {@link MetricReporter} that exports {@link Metric Metrics} via Prometheus Pushgateway.
    + */
    +@PublicEvolving
    +public class PrometheusPushGatewayReporter extends AbstractPrometheusReporter implements
Scheduled {
    +	private static final Logger LOG = LoggerFactory.getLogger(PrometheusPushGatewayReporter.class);
    +
    +	public static final String ARG_HOST = "host";
    +	public static final String ARG_PORT = "port";
    +
    +	public static final char JOB_NAME_SEPARATOR = '-';
    +	public static final String JOB_NAME_PREFIX = "flink" + JOB_NAME_SEPARATOR;
    +
    +	private PushGateway pushGateway;
    +	private final String jobName;
    +
    +	public PrometheusPushGatewayReporter() {
    +		String random = new AbstractID().toString();
    +		jobName = JOB_NAME_PREFIX + random;
    --- End diff --
    
    I'm not sure whether changing how the IDs are generated will break anyone's setup. My
worry is just that this PR might fall through the cracks even after FLINK-9543 is being fixed.
That would be a pity since it is a really nice feature from which users benefit.
    
    Agreed that we should use the TM IDs for the TaskManager metrics.


---

Mime
View raw message