flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #6147: [FLINK-9280][rest] Rework JobSubmitHandler to acce...
Date Wed, 13 Jun 2018 12:54:03 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6147#discussion_r195069312
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
---
    @@ -253,13 +249,13 @@ public void releaseJob(JobID jobId, ExecutionAttemptID executionId)
{
     	private static class CopyFromBlobProcess implements Callable<Path> {
     
     		private final PermanentBlobKey blobKey;
    -		private final Path target;
    +		private final File target;
     		private final boolean isDirectory;
     		private final boolean isExecutable;
     		private final JobID jobID;
     		private final PermanentBlobService blobService;
     
    -		CopyFromBlobProcess(DistributedCacheEntry e, JobID jobID, PermanentBlobService blobService,
Path target) throws Exception {
    +		CopyFromBlobProcess(DistributedCacheEntry e, JobID jobID, PermanentBlobService blobService,
File target) throws Exception {
     				this.isExecutable = e.isExecutable;
     				this.isDirectory = e.isZipped;
    --- End diff --
    
    How about `isZippedDirectory`? `isDirectory` is misleading since the file is not actually
a directory.


---

Mime
View raw message