flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dawidwys <...@git.apache.org>
Subject [GitHub] flink pull request #6134: [FLINK-9538] Make KeyedStateFunction an interface
Date Fri, 08 Jun 2018 07:03:22 GMT
Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6134#discussion_r193968855
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateFunction.java
---
    @@ -25,13 +25,13 @@
      * <p>This functionality is only available through the
      * {@code BroadcastConnectedStream.process(final KeyedBroadcastProcessFunction function)}.
      */
    -public abstract class KeyedStateFunction<K, S extends State> {
    +public interface KeyedStateFunction<K, S extends State> {
    --- End diff --
    
    IMO changing every test that uses this function is not the best practice. Anonymous functions
are still a valid option, so there is no need to change valid tests. I would be in favour
of adding just a single test that tests lambda can be passed.


---

Mime
View raw message