flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #5448: [FLINK-6469] Configure Memory Sizes with units
Date Tue, 05 Jun 2018 07:47:18 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5448
  
    There is no problem reusing old keys, if their default unit was "bytes", because the `MemorySize.parse(...)`
interprets a number as bytes, if there is no unit attached to it.
    
    I did not realize that you switched the config keys already - in that case we need to
backwards support the old keys as well. Also, we need to update all the shell scripts (`config.sh`,
`jobmanager.sh`, `taskmanager.sh` and so on) to be consistent with the new config keys.
    



---

Mime
View raw message