flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sihuazhou <...@git.apache.org>
Subject [GitHub] flink pull request #6087: [FLINK-9410] [yarn] Replace NMClient with NMClient...
Date Mon, 04 Jun 2018 13:04:52 GMT
Github user sihuazhou commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6087#discussion_r192733056
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
    @@ -406,6 +407,43 @@ public void onError(Throwable error) {
     		onFatalError(error);
     	}
     
    +	@Override
    +	public void onContainerStarted(ContainerId containerId, Map<String, ByteBuffer>
allServiceResponse) {
    +		log.info("The container {} started.", containerId);
    +	}
    +
    +	@Override
    +	public void onContainerStatusReceived(ContainerId containerId, ContainerStatus containerStatus)
{
    +	}
    +
    +	@Override
    +	public void onContainerStopped(ContainerId containerId) {
    +		log.info("The container {} is stopped.", containerId);
    +	}
    +
    +	@Override
    +	public void onStartContainerError(ContainerId containerId, Throwable t) {
    +		log.error("Could not start TaskManager in container {}.", containerId, t);
    +
    +		// release the failed container
    +		YarnWorkerNode yarnWorkerNode = workerNodeMap.remove(new ResourceID(containerId.toString()));
    +		resourceManagerClient.releaseAssignedContainer(containerId);
    +		// ask for a new one
    +		requestYarnContainer(yarnWorkerNode.getContainer().getResource(), yarnWorkerNode.getContainer().getPriority());
    +	}
    +
    +	@Override
    +	public void onGetContainerStatusError(ContainerId containerId, Throwable t) {
    +		log.error("Error occurred during get the container {} status.", containerId, t);
    +		onFatalError(t);
    --- End diff --
    
    I think maybe this is not a fatal error.


---

Mime
View raw message