From issues-return-166094-archive-asf-public=cust-asf.ponee.io@flink.apache.org Fri May 11 16:33:01 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1EDA2180647 for ; Fri, 11 May 2018 16:33:00 +0200 (CEST) Received: (qmail 73328 invoked by uid 500); 11 May 2018 14:33:00 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 73305 invoked by uid 99); 11 May 2018 14:33:00 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 May 2018 14:33:00 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id EF569F32C5; Fri, 11 May 2018 14:32:59 +0000 (UTC) From: kailashhd To: issues@flink.apache.org Reply-To: issues@flink.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #5992: [FLINK-8944] [Kinesis Connector] Use listShards in... Content-Type: text/plain Message-Id: <20180511143259.EF569F32C5@git1-us-west.apache.org> Date: Fri, 11 May 2018 14:32:59 +0000 (UTC) Github user kailashhd commented on a diff in the pull request: https://github.com/apache/flink/pull/5992#discussion_r187632455 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java --- @@ -66,13 +66,13 @@ public SentinelSequenceNumber toSentinelSequenceNumber() { public static final String STREAM_TIMESTAMP_DATE_FORMAT = "flink.stream.initpos.timestamp.format"; /** The base backoff time between each describeStream attempt. */ - public static final String STREAM_DESCRIBE_BACKOFF_BASE = "flink.stream.describe.backoff.base"; --- End diff -- I have retained the properties string values as same but changed the variable names to indicate listShards for readability. ---