flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yanghua <...@git.apache.org>
Subject [GitHub] flink pull request #6016: [FLINK-8933] Avoid calling Class#newInstance(part ...
Date Tue, 15 May 2018 07:40:30 GMT
GitHub user yanghua opened a pull request:

    https://github.com/apache/flink/pull/6016

    [FLINK-8933] Avoid calling Class#newInstance(part 2)

    ## What is the purpose of the change
    
    *This pull request avoid calling Class#newInstance*
    
    ## Brief change log
    
      - *Replace `Class#newInstance` to `Class#getDeclaredConstructor#newInstance`*
    
    ## Verifying this change
    
    
    This change is already covered by existing tests*.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes
/ **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanghua/flink FLINK-8933-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6016.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6016
    
----
commit b6408814ac4b29c182ec1f1ed3ea1788fbc7097b
Author: yanghua <yanghua1127@...>
Date:   2018-05-15T07:36:10Z

    [FLINK-8933] Avoid calling Class#newInstance(part 2)

----


---

Mime
View raw message