flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9429) Quickstart E2E not working locally
Date Fri, 25 May 2018 04:10:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490200#comment-16490200
] 

ASF GitHub Bot commented on FLINK-9429:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6074#discussion_r190786548
  
    --- Diff: flink-end-to-end-tests/test-scripts/elasticsearch-common.sh ---
    @@ -61,8 +61,9 @@ function verify_result {
             rm $TEST_DATA_DIR/output
         fi
     
    -    while : ; do
    -      curl 'localhost:9200/index/_search?q=*&pretty&size=21' > $TEST_DATA_DIR/output
    +    # make sure can terminate properly with control-C.
    +    while [ $? -ne 130 ]; do
    --- End diff --
    
    I would prefer that we just wrap the Elasticsearch querying to another function, that
improves readability.
    
    Something along the lines of:
    ```
    function fetch_elasticsearch {
        curl 'localhost:9200/index3/_count?q=*&pretty' > $TEST_DATA_DIR/output
        echo $(grep '\"count\"' $TEST_DATA_DIR/output | awk '{print $3}' | sed 's/\(.*\),/\1
/')
    }
    
    function verify_result {
        local numRecords=$1
    
        if [ -f "$TEST_DATA_DIR/output" ]; then
            rm $TEST_DATA_DIR/output
        fi
    
        while (( $(fetch_elasticsearch) < $numRecords )) ; do
          echo "Waiting for Elasticsearch records ..."
          sleep 1
        done
    }
    ```


> Quickstart E2E not working locally
> ----------------------------------
>
>                 Key: FLINK-9429
>                 URL: https://issues.apache.org/jira/browse/FLINK-9429
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Till Rohrmann
>            Assignee: mingleizhang
>            Priority: Critical
>              Labels: test-stability
>
> The quickstart e2e test is not working locally. It seems as if the job does not produce
anything into Elasticsearch. Furthermore, the test does not terminate with control-C.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message