flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9355) Simplify configuration of local recovery to a simple on/off
Date Mon, 14 May 2018 15:45:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474377#comment-16474377
] 

ASF GitHub Bot commented on FLINK-9355:
---------------------------------------

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6006#discussion_r188002868
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesConfiguration.java
---
    @@ -78,13 +78,13 @@
     
     	private final long timerServiceShutdownTimeout;
     
    -	private final LocalRecoveryConfig.LocalRecoveryMode localRecoveryMode;
    +	private final boolean localRecovery;
    --- End diff --
    
    I would agree to `localRecoveryEnabled` because IIRC the `is` should not be part of boolean
field names, only of the accessor method name.


> Simplify configuration of local recovery to a simple on/off
> -----------------------------------------------------------
>
>                 Key: FLINK-9355
>                 URL: https://issues.apache.org/jira/browse/FLINK-9355
>             Project: Flink
>          Issue Type: Improvement
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>            Priority: Major
>             Fix For: 1.5.0
>
>
> We can change the configuration of local recovery to a simple enabled/disabled choice.
In the future, if a backend can offer different implementations of local recovery, the backend
can offer its own config constants as an expert option.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message