flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9344) Support INTERSECT and INTERSECT ALL for streaming
Date Wed, 23 May 2018 05:17:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16486723#comment-16486723

ASF GitHub Bot commented on FLINK-9344:

Github user walterddr commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/setop/StreamIntersectCoProcessFunction.scala
    @@ -0,0 +1,236 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.table.runtime.setop
    +import org.apache.flink.api.common.state.{ValueState, ValueStateDescriptor}
    +import org.apache.flink.api.common.typeinfo.TypeInformation
    +import org.apache.flink.api.java.tuple.{Tuple2 => JTuple2}
    +import org.apache.flink.api.java.typeutils.TupleTypeInfo
    +import org.apache.flink.configuration.Configuration
    +import org.apache.flink.streaming.api.functions.co.CoProcessFunction
    +import org.apache.flink.table.api.{StreamQueryConfig, Types}
    +import org.apache.flink.table.runtime.join.CRowWrappingMultiOutputCollector
    +import org.apache.flink.table.runtime.types.CRow
    +import org.apache.flink.table.typeutils.TypeCheckUtils.validateEqualsHashCode
    +import org.apache.flink.table.util.Logging
    +import org.apache.flink.types.Row
    +import org.apache.flink.util.Collector
    +class StreamIntersectCoProcessFunction(
    +  resultType: TypeInformation[Row],
    +  queryConfig: StreamQueryConfig,
    +  all: Boolean)
    +  extends CoProcessFunction[CRow, CRow, CRow]
    --- End diff --
    I guess I am confused here:
    There's `CoGroupedStream` with customized `CoGroupFunction` which is already supported
in DataStream API. seems like if we operate on a windowed stream, we can apply the `intersect`
as a `CoGroupFunction`. Is this function solely targeting the non-windowed intersect case.
If so, can we rename the function (also adds to my point: please add Java Doc).

> Support INTERSECT and INTERSECT ALL for streaming
> -------------------------------------------------
>                 Key: FLINK-9344
>                 URL: https://issues.apache.org/jira/browse/FLINK-9344
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API &amp; SQL
>            Reporter: Ruidong Li
>            Assignee: Ruidong Li
>            Priority: Major
> support intersect and intersect all for both SQL and TableAPI

This message was sent by Atlassian JIRA

View raw message