flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9337) Implement AvroDeserializationSchema
Date Tue, 15 May 2018 16:45:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476133#comment-16476133
] 

ASF GitHub Bot commented on FLINK-9337:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5995#discussion_r188350196
  
    --- Diff: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/RegistryAvroDeserializationSchema.java
---
    @@ -0,0 +1,82 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.formats.avro;
    +
    +import org.apache.avro.Schema;
    +import org.apache.avro.generic.GenericDatumReader;
    +import org.apache.avro.generic.GenericRecord;
    +import org.apache.avro.specific.SpecificRecord;
    +
    +import javax.annotation.Nullable;
    +
    +import java.io.IOException;
    +import java.io.ObjectInputStream;
    +
    +/**
    + * Deserialization schema that deserializes from Avro binary format using {@link SchemaCoder}.
    + *
    + * @param <T> type of record it produces
    + */
    +public class RegistryAvroDeserializationSchema<T> extends AvroDeserializationSchema<T>
{
    +	private final SchemaCoder.SchemaCoderProvider schemaCoderProvider;
    +	private transient SchemaCoder schemaCoder;
    +
    +	/**
    +	 * Creates Avro deserialization schema that reads schema from input stream using provided
{@link SchemaCoder}.
    +	 *
    +	 * @param recordClazz         class to which deserialize. Should be either
    +	 *                            {@link SpecificRecord} or {@link GenericRecord}.
    +	 * @param reader              reader's Avro schema. Should be provided if recordClazz
is
    +	 *                            {@link GenericRecord}
    +	 * @param schemaCoderProvider schema provider that allows instantiation of {@link SchemaCoder}
that will be used for
    +	 *                            schema reading
    +	 */
    +	protected RegistryAvroDeserializationSchema(
    +		Class<T> recordClazz,
    +		@Nullable Schema reader,
    +		SchemaCoder.SchemaCoderProvider schemaCoderProvider) {
    +		super(recordClazz, reader);
    +		this.schemaCoderProvider = schemaCoderProvider;
    +		this.schemaCoder = schemaCoderProvider.get();
    +	}
    +
    +	@Override
    +	public T deserialize(byte[] message) {
    +		// read record
    +		try {
    +			getInputStream().setBuffer(message);
    +			Schema writerSchema = schemaCoder.readSchema(getInputStream());
    +			Schema readerSchema = getReaderSchema();
    +
    +			GenericDatumReader<T> datumReader = getDatumReader();
    +
    +			datumReader.setSchema(writerSchema);
    +			datumReader.setExpected(readerSchema);
    +
    +			return datumReader.read(null, getDecoder());
    +		} catch (Exception e) {
    +			throw new RuntimeException("Failed to deserialize Row.", e);
    +		}
    +	}
    +
    +	private void readObject(ObjectInputStream ois) throws ClassNotFoundException, IOException
{
    --- End diff --
    
    See above, would suggest to avoid readObject()


> Implement AvroDeserializationSchema
> -----------------------------------
>
>                 Key: FLINK-9337
>                 URL: https://issues.apache.org/jira/browse/FLINK-9337
>             Project: Flink
>          Issue Type: New Feature
>            Reporter: Dawid Wysakowicz
>            Assignee: Dawid Wysakowicz
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message