flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9325) generate the _meta file only when the writing is totally successful
Date Thu, 10 May 2018 05:23:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469938#comment-16469938
] 

ASF GitHub Bot commented on FLINK-9325:
---------------------------------------

GitHub user sihuazhou opened a pull request:

    https://github.com/apache/flink/pull/5982

    [FLINK-9325][checkpoint]generate the meta file for checkpoint only when the writing is
truly successful

    ## What is the purpose of the change
    
    *This PR in order to enhance the checkpoint's finalization a bit, write the metadata file
first to a temp file and then atomically rename it (with an equivalent workaround for S3).*
    
    
    ## Brief change log
    
      - *write the metadata file first to a temp file and then atomically rename it*
    
    ## Verifying this change
    
    This change is already covered by existing tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes)
      - The S3 file system connector: (no)
    
    ## Documentation
    
    no

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sihuazhou/flink generateTheMetaFileAtomaticly

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5982.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5982
    
----
commit ed37d6d55f3b133aed70e403a7c8b155787462dc
Author: sihuazhou <summerleafs@...>
Date:   2018-05-10T05:17:09Z

    generate the meta file only when the writing is truly successful.

----


> generate the _meta file only when the writing is totally successful
> -------------------------------------------------------------------
>
>                 Key: FLINK-9325
>                 URL: https://issues.apache.org/jira/browse/FLINK-9325
>             Project: Flink
>          Issue Type: Improvement
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.5.0
>            Reporter: Sihua Zhou
>            Assignee: Sihua Zhou
>            Priority: Major
>
> We should generate the _meta file for checkpoint only when the writing is totally successful.
We should write the metadata file first to a temp file and then atomically rename it (with
an equivalent workaround for S3). 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message