flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9187) add prometheus pushgateway reporter
Date Tue, 29 May 2018 13:45:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493540#comment-16493540
] 

ASF GitHub Bot commented on FLINK-9187:
---------------------------------------

Github user lamber-ken commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5857#discussion_r191428603
  
    --- Diff: flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
    @@ -0,0 +1,79 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.metrics.prometheus;
    +
    +import org.apache.flink.annotation.PublicEvolving;
    +import org.apache.flink.metrics.Metric;
    +import org.apache.flink.metrics.MetricConfig;
    +import org.apache.flink.metrics.reporter.MetricReporter;
    +import org.apache.flink.metrics.reporter.Scheduled;
    +import org.apache.flink.util.AbstractID;
    +
    +import io.prometheus.client.CollectorRegistry;
    +import io.prometheus.client.exporter.PushGateway;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +/**
    + * /**
    + * {@link MetricReporter} that exports {@link Metric Metrics} via Prometheus Pushgateway.
    + */
    +@PublicEvolving
    +public class PrometheusPushGatewayReporter extends AbstractPrometheusReporter implements
Scheduled {
    +	private static final Logger LOG = LoggerFactory.getLogger(PrometheusPushGatewayReporter.class);
    +
    +	public static final String ARG_HOST = "host";
    +	public static final String ARG_PORT = "port";
    +
    +	public static final char JOB_NAME_SEPARATOR = '-';
    +	public static final String JOB_NAME_PREFIX = "flink" + JOB_NAME_SEPARATOR;
    +
    +	private PushGateway pushGateway;
    +	private final String jobName;
    +
    +	public PrometheusPushGatewayReporter() {
    +		String random = new AbstractID().toString();
    +		jobName = JOB_NAME_PREFIX + random;
    --- End diff --
    
    May I think your thinking is complicated, here's my idea
    Using different name prefixes to distinguish different flink clusters, and each taskmanager
or jobmanager in the same flink cluster uses the same prefix, it has met our needs.
    We just need to make sure that different clusters use different jobName
    
    
    
    
    if so, the metrics of tm(A) may be covered with the metrics of tm(B), etc


> add prometheus pushgateway reporter
> -----------------------------------
>
>                 Key: FLINK-9187
>                 URL: https://issues.apache.org/jira/browse/FLINK-9187
>             Project: Flink
>          Issue Type: New Feature
>          Components: Metrics
>    Affects Versions: 1.4.2
>            Reporter: lamber-ken
>            Priority: Minor
>              Labels: features
>             Fix For: 1.6.0
>
>
> make flink system can send metrics to prometheus via pushgateway.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message