flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rong Rong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks
Date Tue, 15 May 2018 01:58:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475177#comment-16475177

Rong Rong commented on FLINK-8866:

+1 on the (1) and (2) point, I found like huge trunk of component being copied when trying
create TableSink[Factory/FactoryService] component with current architecture. 

Regrading (3), I think there might be some SinkFunction where fieldName and fieldType is necessary
to validate during initialization of the Sink function (such as JDBC sink, where the underlying
JDBC driver is loaded in runtime I believe). What do you think should we still consider having
them as *optional* part of the configuration?

> Create unified interfaces to configure and instatiate TableSinks
> ----------------------------------------------------------------
>                 Key: FLINK-8866
>                 URL: https://issues.apache.org/jira/browse/FLINK-8866
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API &amp; SQL
>            Reporter: Timo Walther
>            Assignee: Shuyi Chen
>            Priority: Major
> Similar to the efforts done in FLINK-8240. We need unified ways to configure and instantiate
TableSinks. Among other applications, this is necessary in order to declare table sinks in
an environment file of the SQL client. Such that the sink can be used for {{INSERT INTO}}
> Below are a few major changes in mind. 
> 1) Add TableSinkFactory/TableSinkFactoryService similar to TableSourceFactory/TableSourceFactoryService
> 2) Add a common property called "type" with values (source, sink and both) for both TableSource
and TableSink.
> 3) in yaml file, replace "sources" with "tables", and use tableType to identify whether
it's source or sink.

This message was sent by Atlassian JIRA

View raw message