flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8468) Make the connector to take advantage of AMQP features (routing key, exchange and message properties)
Date Mon, 28 May 2018 11:36:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492575#comment-16492575
] 

ASF GitHub Bot commented on FLINK-8468:
---------------------------------------

Github user pduveau commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5410#discussion_r191184148
  
    --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java
---
    @@ -151,7 +151,9 @@ public void open(Configuration config) throws Exception {
     			if (channel == null) {
     				throw new RuntimeException("None of RabbitMQ channels are available");
     			}
    -			setupQueue();
    +			if (rmqConnectionConfig.hasToCreateQueueOnSetup()) {
    --- End diff --
    
    Acceptable in devel environment, in production the application should not be able to operate
not-owned objects and creating an extended class to avoid the queueDeclare on start seems
to be an heavy solution. However, we have a solution and it's complies to our needed. So we
modify to your proposal.


> Make the connector to take advantage of AMQP features (routing key, exchange and message
properties)
> ----------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-8468
>                 URL: https://issues.apache.org/jira/browse/FLINK-8468
>             Project: Flink
>          Issue Type: Improvement
>          Components: RabbitMQ Connector
>    Affects Versions: 1.4.0
>            Reporter: Ph.Duveau
>            Priority: Major
>
> Make the connector to take advantage of AMQP features by adding a constructor and an
interface to implement



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message