flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7850) Given each maven profile an activation property
Date Wed, 23 May 2018 08:05:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16486881#comment-16486881
] 

ASF GitHub Bot commented on FLINK-7850:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5840#discussion_r190155490
  
    --- Diff: flink-libraries/flink-ml/pom.xml ---
    @@ -116,6 +119,9 @@
     			<id>default</id>
     			<activation>
     				<activeByDefault>true</activeByDefault>
    +				<property>
    +					<name>default</name>
    --- End diff --
    
    This profile is never activated from the command-line and doesn't require the property.


> Given each maven profile an activation property
> -----------------------------------------------
>
>                 Key: FLINK-7850
>                 URL: https://issues.apache.org/jira/browse/FLINK-7850
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Priority: Major
>              Labels: starter
>
> We should give every maven profile an activation property so that they can be activated
with {{-Dabcde}}. This makes them a lot easier to work with in scripts that want to control
profile activation, since you can just append {{-D}} switches. This doesn't work with the
{{-P}} switch as it can only be specified once.
> {code}
> <activation>
> 	<property>
> 		<name>profile_name_or_something</name>
> 	</property>
> </activation>
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message