flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7386) Flink Elasticsearch 5 connector is not compatible with Elasticsearch 5.2+ client
Date Fri, 25 May 2018 04:07:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490198#comment-16490198
] 

ASF GitHub Bot commented on FLINK-7386:
---------------------------------------

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/6043
  
    One more thing to clarify:
    When planning to switch to REST, are we speaking of an implementation that works directly
against Elasticsearch's REST API? Or are we thinking of using Elasticsearch's [RestHighLevelClient](https://snapshots.elastic.co/javadoc/org/elasticsearch/client/elasticsearch-rest-high-level-client/7.0.0-alpha1-SNAPSHOT/org/elasticsearch/client/RestHighLevelClient.html)?
    
    I would assume the latter, but IMO we would not be able to avoid yet again having a common
base module across future versions (e.g. across ES 6.x, 7.x, and so on), even if we make a
clean cut now.
    So, I have the feeling that the main problem here isn't that we are sharing code between
versions, but the fact that our base shared code isn't future-proof enough for potential 3rd
party API breaks.
    
    That's the main reason why I'm proposing not to expose Elasticsearch classes anymore through
base class APIs in the shared module.


> Flink Elasticsearch 5 connector is not compatible with Elasticsearch 5.2+ client
> --------------------------------------------------------------------------------
>
>                 Key: FLINK-7386
>                 URL: https://issues.apache.org/jira/browse/FLINK-7386
>             Project: Flink
>          Issue Type: Improvement
>          Components: ElasticSearch Connector
>            Reporter: Dawid Wysakowicz
>            Assignee: Fang Yong
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> In Elasticsearch 5.2.0 client the class {{BulkProcessor}} was refactored and has no longer
the method {{add(ActionRequest)}}.
> For more info see: https://github.com/elastic/elasticsearch/pull/20109



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message