flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3952) Bump Netty to 4.1
Date Wed, 30 May 2018 09:39:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494941#comment-16494941

ASF GitHub Bot commented on FLINK-3952:

Github user pnowojski commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/ReadOnlySlicedNetworkBuffer.java
    @@ -75,12 +75,12 @@ private ReadOnlySlicedNetworkBuffer(ByteBuf buffer, int index, int
length, int m
     	public ByteBuf unwrap() {
    -		return super.unwrap().unwrap();
    +		return super.unwrap();
    --- End diff --
    Necessary for the upgrade, otherwise our tests (including `ITCases`) are failing. In upgraded
version there is a different structure of nested classes in case of using slices of readonly
buffers. Possibly this is a bug fix for a bug, that didn't show up in older netty.

> Bump Netty to 4.1
> -----------------
>                 Key: FLINK-3952
>                 URL: https://issues.apache.org/jira/browse/FLINK-3952
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core, Network
>            Reporter: rektide de la fey
>            Assignee: Piotr Nowojski
>            Priority: Major
>              Labels: netty
> Netty 4.1 is about to release final. This release has [a number of significant enhancements|http://netty.io/wiki/new-and-noteworthy-in-4.1.html],
and in particular I find HTTP/2 codecs to be incredibly desirable to have. 
> Additionally, hopefully, the [Hadoop patches for Netty 4.1|https://issues.apache.org/jira/browse/HADOOP-11716]
get some tests and get merged, & I believe if/when that happens it'll be important for
Flink to also be using the new Netty minor version.

This message was sent by Atlassian JIRA

View raw message