flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3952) Bump Netty to 4.1
Date Thu, 24 May 2018 11:30:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488819#comment-16488819
] 

ASF GitHub Bot commented on FLINK-3952:
---------------------------------------

GitHub user pnowojski opened a pull request:

    https://github.com/apache/flink/pull/6071

    [FLINK-3952][runtine] Upgrade to Netty 4.1

    This PR adjusts our code to work with Netty 4.1. It also includes possible bug fix to
file uploading cleanup in FileUploadHandler and HttpRequestHandler. For mor information look
here:
    
    https://github.com/netty/netty/issues/7611
    
    First commit is only for having green travis and will be dropped once new `flink-shadded-netty`
will be released.
    
    ## Verifying this change
    
    This change is covered by variety of pre existing tests. Furthermore I have manually verified
that issue mentioned by @uce in the commit message here: https://github.com/apache/flink/commit/d92e422ec7089376583a8f57043274d236c340a4
    doesn't happen: 
    - I have reproduced this issue on a test cluster with Flink 1.0-XXX
    - I have verified that the same job passes without any problems after upgrading to Netty
4.1
    
    I have also run our network benchmark suite and verified that there are no performance
changes after this change.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (**yes** / no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes
/ **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (**yes** / no / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not
documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pnowojski/flink f3952

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6071.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6071
    
----
commit 7b3be7c9ebac7392136ed85bca4664559710552e
Author: Piotr Nowojski <piotr.nowojski@...>
Date:   2018-05-14T11:46:08Z

    [hotfix][tests] Report failure with error level instead of debug

commit afaf1d5181c7133a040bf3881723e240145a4b0a
Author: Piotr Nowojski <piotr.nowojski@...>
Date:   2018-05-16T19:26:36Z

    [FLINK-9386] Embed netty router
    
    This commit replaces netty-router dependency with our own version of it, which is
    simplified and adds guarantees about order of matching router patterns.
    
    This is a prerequisite for FLINK-3952. netty-router 1.10 is incompatible with
    Netty 4.1, while netty-router 2.2.0 brakes a compatibility in a way that we
    were unable to use it.

commit 26bc92db0863bf53e60164ab5f6b92ac3b424506
Author: Piotr Nowojski <piotr.nowojski@...>
Date:   2018-05-14T10:30:31Z

    Embed flink-shaded-netty-4

commit 94a4cc2237b5dac0c004ec192eb4d7f1b782e5f2
Author: Piotr Nowojski <piotr.nowojski@...>
Date:   2018-05-16T19:27:22Z

    [FLINK-3952][runtine] Upgrade to Netty 4.1
    
    This commit includes possible bug fix to file uploading cleanup in FileUploadHandler and
    HttpRequestHandler. For mor information look here:
    
    https://github.com/netty/netty/issues/7611

----


> Bump Netty to 4.1
> -----------------
>
>                 Key: FLINK-3952
>                 URL: https://issues.apache.org/jira/browse/FLINK-3952
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core, Network
>            Reporter: rektide de la fey
>            Assignee: Piotr Nowojski
>            Priority: Major
>              Labels: netty
>
> Netty 4.1 is about to release final. This release has [a number of significant enhancements|http://netty.io/wiki/new-and-noteworthy-in-4.1.html],
and in particular I find HTTP/2 codecs to be incredibly desirable to have. 
> Additionally, hopefully, the [Hadoop patches for Netty 4.1|https://issues.apache.org/jira/browse/HADOOP-11716]
get some tests and get merged, & I believe if/when that happens it'll be important for
Flink to also be using the new Netty minor version.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message