flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GJL <...@git.apache.org>
Subject [GitHub] flink pull request #6069: [FLINK-9416] Make all RestClusterClient calls retr...
Date Thu, 24 May 2018 14:30:22 GMT
Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6069#discussion_r190605670
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
    @@ -314,7 +319,8 @@ public JobSubmissionResult submitJob(JobGraph jobGraph, ClassLoader
classLoader)
     
     		log.info("Requesting blob server port.");
     		CompletableFuture<BlobServerPortResponseBody> portFuture = sendRequest(
    -			BlobServerPortHeaders.getInstance());
    +			BlobServerPortHeaders.getInstance(),
    +			EmptyMessageParameters.getInstance());
    --- End diff --
    
    This is not needed. There should be an overload of `sendRequest` that does it.


---

Mime
View raw message