flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #6043: [FLINK-7386] evolve RequestIndexer API to make it ...
Date Wed, 23 May 2018 05:38:15 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6043#discussion_r190126707
  
    --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/RequestIndexer.java
---
    @@ -21,18 +21,56 @@
     import org.apache.flink.annotation.PublicEvolving;
     
     import org.elasticsearch.action.ActionRequest;
    +import org.elasticsearch.action.delete.DeleteRequest;
    +import org.elasticsearch.action.index.IndexRequest;
    +import org.elasticsearch.action.update.UpdateRequest;
     
     /**
    - * Users add multiple {@link ActionRequest ActionRequests} to a {@link RequestIndexer}
to prepare
    + * Users add multiple delete, index or update requests to a {@link RequestIndexer} to
prepare
      * them for sending to an Elasticsearch cluster.
      */
     @PublicEvolving
    -public interface RequestIndexer {
    +public abstract class RequestIndexer {
     
     	/**
     	 * Add multiple {@link ActionRequest} to the indexer to prepare for sending requests
to Elasticsearch.
     	 *
     	 * @param actionRequests The multiple {@link ActionRequest} to add.
    +	 * @deprecated use the {@link DeleteRequest}, {@link IndexRequest} or {@Up}
    --- End diff --
    
    typo at the end.


---

Mime
View raw message