flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #5977: [FLINK-9295][kafka] Fix transactional.id collision...
Date Tue, 15 May 2018 08:34:20 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5977#discussion_r188205000
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/functions/RuntimeContext.java
---
    @@ -71,6 +71,17 @@
     	@PublicEvolving
     	MetricGroup getMetricGroup();
     
    +	/**
    +	 * Returned value is guaranteed to be unique between operators within the same job and
to be
    +	 * stable and the same across job submissions.
    +	 *
    +	 * <p>This operation is currently only supported in Streaming (DataStream) contexts.
    +	 *
    +	 * @return String representation of the operator's unique id.
    +	 */
    +	@PublicEvolving
    +	String getOperatorUniqueID();
    --- End diff --
    
    I'm slightly leaning towards Stephan's suggestion, which I also agree is the better solution
for this case.
    
    It might be ok to have this as a "hidden" API for now anyways, since 1) it is marked `@PublicEvolving`,
and 2) the API was added in quite a short timeframe.
    If we want this fix in 1.5, I wouldn't suggest "fully" exposing it.


---

Mime
View raw message