flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From suez1224 <...@git.apache.org>
Subject [GitHub] flink pull request #5901: [FLINK-9235][Security] Add integration tests for Y...
Date Sun, 06 May 2018 18:11:00 GMT
Github user suez1224 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5901#discussion_r186298337
  
    --- Diff: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
---
    @@ -85,54 +88,75 @@ public void checkForProhibitedLogContents() {
     	public void testDetachedMode() throws InterruptedException, IOException {
     		LOG.info("Starting testDetachedMode()");
     		addTestAppender(FlinkYarnSessionCli.class, Level.INFO);
    -		Runner runner =
    -			startWithArgs(new String[]{"-j", flinkUberjar.getAbsolutePath(),
    -						"-t", flinkLibFolder.getAbsolutePath(),
    -						"-n", "1",
    -						"-jm", "768",
    -						"-tm", "1024",
    -						"--name", "MyCustomName", // test setting a custom name
    -						"--detached"},
    -				"Flink JobManager is now running on", RunTypes.YARN_SESSION);
    -
    +		File exampleJarLocation = getTestJarPath("StreamingWordCount.jar");
    --- End diff --
    
    We need to add the jar for the new mode, otherwise no TaskExecutor will be brought up.


---

Mime
View raw message