flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #5940: [FLINK-8690][table]Support group window distinct a...
Date Fri, 04 May 2018 11:36:01 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5940#discussion_r185955967
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
    @@ -641,7 +641,8 @@ class AggregationCodeGenerator(
                    |      java.util.Map.Entry entry = (java.util.Map.Entry) mergeIt$i.next();
                    |      Object k = entry.getKey();
                    |      Long v = (Long) entry.getValue();
    -               |      if (aDistinctAcc$i.add(k, v)) {
    +               |      if (aDistinctAcc$i.add(
    --- End diff --
    
    The key in the entry is a `Row` already


---

Mime
View raw message