From issues-return-164412-archive-asf-public=cust-asf.ponee.io@flink.apache.org Sat Apr 28 12:19:08 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 97ED0180649 for ; Sat, 28 Apr 2018 12:19:07 +0200 (CEST) Received: (qmail 78764 invoked by uid 500); 28 Apr 2018 10:19:06 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 78755 invoked by uid 99); 28 Apr 2018 10:19:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 28 Apr 2018 10:19:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E2FF8C0010 for ; Sat, 28 Apr 2018 10:19:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 3FMZxzu8qq7w for ; Sat, 28 Apr 2018 10:19:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 204AB5FBAB for ; Sat, 28 Apr 2018 10:19:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 03998E1299 for ; Sat, 28 Apr 2018 10:19:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 559FD2427B for ; Sat, 28 Apr 2018 10:19:00 +0000 (UTC) Date: Sat, 28 Apr 2018 10:19:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-9270) Upgrade RocksDB to 5.11.3, and resolve concurrent test invocation problem of @RetryOnFailure MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-9270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457520#comment-16457520 ] ASF GitHub Bot commented on FLINK-9270: --------------------------------------- Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5937 @bowenli86 I already wanted to do this for some time but unfortunately we currently cannot upgrade RocksDB to any higher version than what is used in master. It seems like there is again a performance regression for the merge operator for all newer versions. If you check your Travis runs, you will see that `RocksDBPerformanceTest.testRocksDbMergePerformance` fails all the time. I have commented about this problem in the RocksDB issue tracker, but no reaction so far. If you agree, please close this PR. > Upgrade RocksDB to 5.11.3, and resolve concurrent test invocation problem of @RetryOnFailure > -------------------------------------------------------------------------------------------- > > Key: FLINK-9270 > URL: https://issues.apache.org/jira/browse/FLINK-9270 > Project: Flink > Issue Type: Improvement > Components: State Backends, Checkpointing > Affects Versions: 1.5.0 > Reporter: Bowen Li > Assignee: Bowen Li > Priority: Major > Fix For: 1.6.0 > > > Upgrade RocksDB to 5.11.3 to take latest bug fixes > Besides, I found that unit tests annotated with {{@RetryOnFailure}} will be run concurrently if there's only {{try}} clause without a {{catch}} following. For example, sometimes, {{RocksDBPerformanceTest.testRocksDbMergePerformance()}} will actually be running in 3 concurrent invocations, and multiple concurrent write to RocksDB result in errors. -- This message was sent by Atlassian JIRA (v7.6.3#76005)