From issues-return-163738-archive-asf-public=cust-asf.ponee.io@flink.apache.org Tue Apr 24 16:50:11 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E0193180679 for ; Tue, 24 Apr 2018 16:50:10 +0200 (CEST) Received: (qmail 91794 invoked by uid 500); 24 Apr 2018 14:50:08 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 91757 invoked by uid 99); 24 Apr 2018 14:50:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Apr 2018 14:50:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 91F86C02CF for ; Tue, 24 Apr 2018 14:50:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id IwmEmjLPSsL7 for ; Tue, 24 Apr 2018 14:50:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E343E5F238 for ; Tue, 24 Apr 2018 14:50:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E29C6E0BC2 for ; Tue, 24 Apr 2018 14:50:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3E290241CC for ; Tue, 24 Apr 2018 14:50:01 +0000 (UTC) Date: Tue, 24 Apr 2018 14:50:01 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-9138) Enhance BucketingSink to also flush data by time interval MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-9138?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1644= 9984#comment-16449984 ]=20 ASF GitHub Bot commented on FLINK-9138: --------------------------------------- Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5860#discussion_r183753866 =20 --- Diff: flink-connectors/flink-connector-filesystem/src/main/java/org= /apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java --- @@ -87,9 +87,11 @@ * and a rolling counter. For example the file {@code "part-1-17"} con= tains the data from * {@code subtask 1} of the sink and is the {@code 17th} bucket create= d by that subtask. Per default * the part prefix is {@code "part"} but this can be configured using = {@link #setPartPrefix(String)}. - * When a part file becomes bigger than the user-specified batch size = the current part file is closed, - * the part counter is increased and a new part file is created. The b= atch size defaults to {@code 384MB}, - * this can be configured using {@link #setBatchSize(long)}. + * When a part file becomes bigger than the user-specified batch size = or when the part file becomes older + * than the user-specified roll over interval the current part file is= closed,the part counter is increased --- End diff -- =20 Add space `closed,the` -> `closed, the` > Enhance BucketingSink to also flush data by time interval > --------------------------------------------------------- > > Key: FLINK-9138 > URL: https://issues.apache.org/jira/browse/FLINK-9138 > Project: Flink > Issue Type: Improvement > Components: filesystem-connector > Affects Versions: 1.4.2 > Reporter: Narayanan Arunachalam > Priority: Major > > BucketingSink now supports flushing data to the=C2=A0file system by size = limit and by period of inactivity. It will be useful to also flush data by= =C2=A0a=C2=A0specified time period. This way, the data will be written out = when write throughput is low but there is no significant time period gaps b= etween the writes. This=C2=A0reduces ETA for the data in the file system an= d should help move the checkpoints faster as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)