flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8835) Fix TaskManager config keys
Date Wed, 04 Apr 2018 08:08:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425150#comment-16425150
] 

ASF GitHub Bot commented on FLINK-8835:
---------------------------------------

Github user zhangminglei commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5808#discussion_r179056634
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java
---
    @@ -299,15 +299,15 @@
     	/**
     	 * Flag indicating whether to start a thread, which repeatedly logs the memory usage
of the JVM.
     	 *
    -	 * @deprecated use {@link TaskManagerOptions#DEBUG_MEMORY_USAGE_START_LOG_THREAD} instead
    +	 * @deprecated use {@link TaskManagerOptions#DEBUG_MEMORY_LOG} instead
     	 */
     	@Deprecated
    -	public static final String TASK_MANAGER_DEBUG_MEMORY_USAGE_START_LOG_THREAD = "taskmanager.debug.memory.startLogThread";
    +	public static final String TASK_MANAGER_DEBUG_MEMORY_LOG = "taskmanager.debug.memory.log";
    --- End diff --
    
    Ah. Makes better sense to me.


> Fix TaskManager config keys
> ---------------------------
>
>                 Key: FLINK-8835
>                 URL: https://issues.apache.org/jira/browse/FLINK-8835
>             Project: Flink
>          Issue Type: Bug
>          Components: TaskManager
>            Reporter: Stephan Ewen
>            Assignee: mingleizhang
>            Priority: Blocker
>              Labels: easy-fix
>             Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming scheme. We need
to clear those up before the release. I would also suggest to keep the key names short, because
that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also make some
of the existing keys more hierarchical harmonize them with the common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} => {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} => {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} => {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} => {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}} {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> * {{taskmanager.registration.timeout}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message