flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8703) Migrate tests from LocalFlinkMiniCluster to MiniClusterResource
Date Mon, 16 Apr 2018 15:06:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439554#comment-16439554
] 

ASF GitHub Bot commented on FLINK-8703:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5665#discussion_r181775179
  
    --- Diff: flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/WebFrontendITCase.java
---
    @@ -127,14 +137,18 @@ public void testResponseHeaders() throws Exception {
     		Assert.assertEquals("application/json; charset=UTF-8", taskManagerConnection.getContentType());
     
     		// check headers in case of an error
    -		URL notFoundJobUrl = new URL("http://localhost:" + port + "/jobs/dontexist");
    +		URL notFoundJobUrl = new URL("http://localhost:" + CLUSTER.getWebUIPort() + "/jobs/dontexist");
     		HttpURLConnection notFoundJobConnection = (HttpURLConnection) notFoundJobUrl.openConnection();
     		notFoundJobConnection.setConnectTimeout(100000);
     		notFoundJobConnection.connect();
     		if (notFoundJobConnection.getResponseCode() >= 400) {
     			// we don't set the content-encoding header
     			Assert.assertNull(notFoundJobConnection.getContentEncoding());
    -			Assert.assertEquals("text/plain; charset=UTF-8", notFoundJobConnection.getContentType());
    +			if (Objects.equals("flip6", System.getProperty("codebase"))) {
    --- End diff --
    
    this must be updated to "new"


> Migrate tests from LocalFlinkMiniCluster to MiniClusterResource
> ---------------------------------------------------------------
>
>                 Key: FLINK-8703
>                 URL: https://issues.apache.org/jira/browse/FLINK-8703
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>            Reporter: Aljoscha Krettek
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message