flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView
Date Wed, 25 Apr 2018 15:01:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452409#comment-16452409
] 

ASF GitHub Bot commented on FLINK-8689:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5555#discussion_r184037303
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
    @@ -151,8 +157,36 @@ class AggregationCodeGenerator(
           }
         }
     
    -    // initialize and create data views
    -    addReusableDataViews()
    +    // get distinct filter of acc fields for each aggregate functions
    +    val distinctAccType = s"${classOf[DistinctAccumulator[_, _]].getName}"
    +
    +    val distinctAggs: Array[Seq[DataViewSpec[_]]] = isDistinctAggs.zipWithIndex.map {
    +      case (isDistinctAgg, idx) => if (isDistinctAgg) {
    +        val fieldIndex: Int = aggFields(idx)(0)
    +        val mapViewTypeInfo = new MapViewTypeInfo(
    +          physicalInputTypes(fieldIndex), BasicTypeInfo.LONG_TYPE_INFO)
    +        Seq(
    +          MapViewSpec(
    +            "distinctAgg" + idx + "_field" + fieldIndex,
    --- End diff --
    
    I think we can remove the `"_field" + fieldIndex` postfix. Once we add support for distinct
multi-argument function, we have to use a single `MapViewSpec` with a `Row` that holds all
arguments.


> Add runtime support of distinct filter using MapView 
> -----------------------------------------------------
>
>                 Key: FLINK-8689
>                 URL: https://issues.apache.org/jira/browse/FLINK-8689
>             Project: Flink
>          Issue Type: Sub-task
>            Reporter: Rong Rong
>            Assignee: Rong Rong
>            Priority: Major
>
> This ticket should cover distinct aggregate function support to codegen for *AggregateCall*, where
*isDistinct* fields is set to true.
> This can be verified using the following SQL, which is not currently producing correct
results.
> {code:java}
> SELECT
>   a,
>   SUM(b) OVER (PARTITION BY a ORDER BY proctime ROWS BETWEEN 5 PRECEDING AND CURRENT
ROW)
> FROM
>   MyTable{code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message