flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView
Date Thu, 19 Apr 2018 15:16:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444218#comment-16444218
] 

ASF GitHub Bot commented on FLINK-8689:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5555#discussion_r182254735
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
    @@ -327,19 +392,41 @@ class AggregationCodeGenerator(
             for (i <- aggs.indices) yield
     
               if (partialResults) {
    -            j"""
    -               |    output.setField(
    -               |      ${aggMapping(i)},
    -               |      (${accTypes(i)}) accs.getField($i));""".stripMargin
    +            if (isDistinctAggs(i)) {
    +
    +              j"""
    +                 |    $distinctAccType distinctAcc$i = ($distinctAccType) accs.getField($i);
    +                 |    output.setField(
    +                 |      ${aggMapping(i)},
    +                 |      (${accTypes(i)}) distinctAcc$i.getRealAcc());""".stripMargin
    --- End diff --
    
    We need to forward the distinct maps as well. `partialResults` is used when an operator
needs to emit partial aggregation results such as a combine function in batch execution. So
we don't need to distinguish the `isDistinctAggs(i)` case here.


> Add runtime support of distinct filter using MapView 
> -----------------------------------------------------
>
>                 Key: FLINK-8689
>                 URL: https://issues.apache.org/jira/browse/FLINK-8689
>             Project: Flink
>          Issue Type: Sub-task
>            Reporter: Rong Rong
>            Assignee: Rong Rong
>            Priority: Major
>
> This ticket should cover distinct aggregate function support to codegen for *AggregateCall*, where
*isDistinct* fields is set to true.
> This can be verified using the following SQL, which is not currently producing correct
results.
> {code:java}
> SELECT
>   a,
>   SUM(b) OVER (PARTITION BY a ORDER BY proctime ROWS BETWEEN 5 PRECEDING AND CURRENT
ROW)
> FROM
>   MyTable{code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message