flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8428) Implement stream-stream non-window left outer join
Date Thu, 19 Apr 2018 11:19:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443903#comment-16443903
] 

ASF GitHub Bot commented on FLINK-8428:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5327#discussion_r182476347
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/NonWindowOuterJoin.scala
---
    @@ -0,0 +1,303 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.table.runtime.join
    +
    +import org.apache.flink.api.common.state._
    +import org.apache.flink.api.common.typeinfo.TypeInformation
    +import org.apache.flink.api.java.tuple.{Tuple2 => JTuple2}
    +import org.apache.flink.configuration.Configuration
    +import org.apache.flink.streaming.api.functions.co.CoProcessFunction
    +import org.apache.flink.table.api.{StreamQueryConfig, Types}
    +import org.apache.flink.table.runtime.types.CRow
    +import org.apache.flink.types.Row
    +import org.apache.flink.util.Collector
    +
    +/**
    +  * Connect data for left stream and right stream. Base class for stream non-window outer
Join.
    +  *
    +  * @param leftType        the input type of left stream
    +  * @param rightType       the input type of right stream
    +  * @param resultType      the output type of join
    +  * @param genJoinFuncName the function code of other non-equi condition
    +  * @param genJoinFuncCode the function name of other non-equi condition
    +  * @param isLeftJoin      the type of join, whether it is the type of left join
    +  * @param queryConfig     the configuration for the query to generate
    +  */
    +abstract class NonWindowOuterJoin(
    +    leftType: TypeInformation[Row],
    +    rightType: TypeInformation[Row],
    +    resultType: TypeInformation[CRow],
    +    genJoinFuncName: String,
    +    genJoinFuncCode: String,
    +    isLeftJoin: Boolean,
    +    queryConfig: StreamQueryConfig)
    +  extends NonWindowJoin(
    +    leftType,
    +    rightType,
    +    resultType,
    +    genJoinFuncName,
    +    genJoinFuncCode,
    +    queryConfig) {
    +
    +  // result row, all fields from right will be null. Used for output when there is no
matched rows.
    +  protected var leftResultRow: Row = _
    +  // result row, all fields from left will be null. Used for output when there is no
matched rows.
    +  protected var rightResultRow: Row = _
    +  // how many matched rows from the right table for each left row. Index 0 is used for
left
    +  // stream, index 1 is used for right stream.
    +  protected var joinCntState: Array[MapState[Row, Long]] = _
    +
    +  override def open(parameters: Configuration): Unit = {
    +    super.open(parameters)
    +
    +    leftResultRow = new Row(resultType.getArity)
    +    rightResultRow = new Row(resultType.getArity)
    +
    +    joinCntState = new Array[MapState[Row, Long]](2)
    +    val leftJoinCntStateDescriptor = new MapStateDescriptor[Row, Long](
    +      "leftJoinCnt", leftType, Types.LONG.asInstanceOf[TypeInformation[Long]])
    +    joinCntState(0) = getRuntimeContext.getMapState(leftJoinCntStateDescriptor)
    +    val rightJoinCntStateDescriptor = new MapStateDescriptor[Row, Long](
    +      "rightJoinCnt", rightType, Types.LONG.asInstanceOf[TypeInformation[Long]])
    +    joinCntState(1) = getRuntimeContext.getMapState(rightJoinCntStateDescriptor)
    +
    +    LOG.debug(s"Instantiating NonWindowOuterJoin")
    +  }
    +
    +  /**
    +    * Join current row with other side rows. Preserve current row if there are no matched
rows
    +    * from other side.
    +    */
    +  def preservedJoin(
    +      inputRow: Row,
    +      inputRowFromLeft: Boolean,
    +      otherSideState: MapState[Row, JTuple2[Long, Long]],
    +      curProcessTime: Long): Long = {
    +
    +    val otherSideIterator = otherSideState.iterator()
    +    while (otherSideIterator.hasNext) {
    +      val otherSideEntry = otherSideIterator.next()
    +      val otherSideRow = otherSideEntry.getKey
    +      val otherSideCntAndExpiredTime = otherSideEntry.getValue
    +      // join
    +      cRowWrapper.setTimes(otherSideCntAndExpiredTime.f0)
    +      callJoinFunction(inputRow, inputRowFromLeft, otherSideRow, cRowWrapper)
    +      // clear expired data. Note: clear after join to keep closer to the original semantics
    +      if (stateCleaningEnabled && curProcessTime >= otherSideCntAndExpiredTime.f1)
{
    +        otherSideIterator.remove()
    +      }
    +    }
    +    val joinCnt = cRowWrapper.getEmitCnt
    +    // The result is NULL from the other side, if there is no match.
    +    if (joinCnt == 0) {
    +      cRowWrapper.setTimes(1)
    +      collectAppendNull(inputRow, inputRowFromLeft, cRowWrapper)
    +    }
    +    joinCnt
    +  }
    +
    +  /**
    +    * Join current row with other side rows. Retract previous output row if matched condition
    +    * changed, i.e, matched condition is changed from matched to unmatched or vice versa.
    +    */
    +  def retractJoin(
    +      value: CRow,
    +      inputRowFromLeft: Boolean,
    +      currentSideState: MapState[Row, JTuple2[Long, Long]],
    +      otherSideState: MapState[Row, JTuple2[Long, Long]],
    +      curProcessTime: Long): Unit = {
    +
    +    val inputRow = value.row
    +    val otherSideIterator = otherSideState.iterator()
    +    // number of record in current side, here we only check whether number equals to
0 or 1.
    +    val recordNum: Long = recordNumInState(currentSideState)
    +
    +    while (otherSideIterator.hasNext) {
    +      val otherSideEntry = otherSideIterator.next()
    +      val otherSideRow = otherSideEntry.getKey
    +      val otherSideCntAndExpiredTime = otherSideEntry.getValue
    +      cRowWrapper.setTimes(otherSideCntAndExpiredTime.f0)
    +
    +      // retract previous preserved record append with null
    +      if (recordNum == 1 && value.change) {
    +        cRowWrapper.setChange(false)
    +        collectAppendNull(otherSideRow, !inputRowFromLeft, cRowWrapper)
    +        cRowWrapper.setChange(true)
    +      }
    +      // do normal join
    +      callJoinFunction(inputRow, inputRowFromLeft, otherSideRow, cRowWrapper)
    +
    +      // output preserved record append with null if have to
    +      if (!value.change && recordNum == 0) {
    +        cRowWrapper.setChange(true)
    +        collectAppendNull(otherSideRow, !inputRowFromLeft, cRowWrapper)
    +        cRowWrapper.setChange(false)
    +      }
    +      // clear expired data. Note: clear after join to keep closer to the original semantics
    +      if (stateCleaningEnabled && curProcessTime >= otherSideCntAndExpiredTime.f1)
{
    +        otherSideIterator.remove()
    +      }
    +    }
    +  }
    +
    +  /**
    +    * Join current row with other side rows when contains non-equal predicates. Retract
previous
    +    * output row if matched condition changed, i.e, matched condition is changed from
matched to
    +    * unmatched or vice versa.
    +    */
    +  def retractJoinWithNonEquiPreds(
    +      value: CRow,
    +      inputRowFromLeft: Boolean,
    +      otherSideState: MapState[Row, JTuple2[Long, Long]],
    +      joinCntIdx: Int,
    +      curProcessTime: Long): Unit = {
    +
    +    val inputRow = value.row
    +    val otherSideIterator = otherSideState.iterator()
    +    while (otherSideIterator.hasNext) {
    +      val otherSideEntry = otherSideIterator.next()
    +      val otherSideRow = otherSideEntry.getKey
    +      val otherSideCntAndExpiredTime = otherSideEntry.getValue
    +
    +      cRowWrapper.setLazyOutput(true)
    +      cRowWrapper.setRow(null)
    +      callJoinFunction(inputRow, inputRowFromLeft, otherSideRow, cRowWrapper)
    +      cRowWrapper.setLazyOutput(false)
    +      if (cRowWrapper.getRow() != null) {
    +        cRowWrapper.setTimes(otherSideCntAndExpiredTime.f0)
    +        val joinCnt = joinCntState(1 - joinCntIdx).get(otherSideRow)
    +        if (value.change) {
    +          joinCntState(1 - joinCntIdx).put(otherSideRow, joinCnt + 1L)
    +          if (joinCnt == 0) {
    +            // retract previous non matched result row
    +            cRowWrapper.setChange(false)
    +            collectAppendNull(otherSideRow, !inputRowFromLeft, cRowWrapper)
    +            cRowWrapper.setChange(true)
    +          }
    +          // do normal join
    +          callJoinFunction(inputRow, inputRowFromLeft, otherSideRow, cRowWrapper)
    +        } else {
    +          joinCntState(1 - joinCntIdx).put(otherSideRow, joinCnt - 1L)
    +          // do normal join
    +          callJoinFunction(inputRow, inputRowFromLeft, otherSideRow, cRowWrapper)
    +          if (joinCnt == 1) {
    +            // output non matched result row
    +            cRowWrapper.setChange(true)
    +            collectAppendNull(otherSideRow, !inputRowFromLeft, cRowWrapper)
    +            cRowWrapper.setChange(false)
    +          }
    +        }
    +      }
    +      if (stateCleaningEnabled && curProcessTime >= otherSideCntAndExpiredTime.f1)
{
    +        otherSideIterator.remove()
    +      }
    +    }
    +  }
    +
    +  /**
    +    * Removes records which are expired from state. Registers a new timer if the state
still
    +    * holds records after the clean-up. Also, clear joinCnt map state when clear rowMapState.
    +    */
    +  def expireOutTimeRow(
    +      curTime: Long,
    +      rowMapState: MapState[Row, JTuple2[Long, Long]],
    +      timerState: ValueState[Long],
    +      isLeft: Boolean,
    +      joinCntState: Array[MapState[Row, Long]],
    +      ctx: CoProcessFunction[CRow, CRow, CRow]#OnTimerContext): Unit = {
    +
    +    val joinCntIdx = getJoinCntIndex(isLeft)
    +    val rowMapIter = rowMapState.iterator()
    +    var validTimestamp: Boolean = false
    +
    +    while (rowMapIter.hasNext) {
    +      val mapEntry = rowMapIter.next()
    +      val recordExpiredTime = mapEntry.getValue.f1
    +      if (recordExpiredTime <= curTime) {
    +        rowMapIter.remove()
    +        joinCntState(joinCntIdx).remove(mapEntry.getKey)
    +      } else {
    +        // we found a timestamp that is still valid
    +        validTimestamp = true
    +      }
    +    }
    +    // If the state has non-expired timestamps, register a new timer.
    +    // Otherwise clean the complete state for this input.
    +    if (validTimestamp) {
    +      val cleanupTime = curTime + maxRetentionTime
    +      ctx.timerService.registerProcessingTimeTimer(cleanupTime)
    +      timerState.update(cleanupTime)
    +    } else {
    +      timerState.clear()
    +      rowMapState.clear()
    +      if (isLeft == isLeftJoin) {
    +        joinCntState(joinCntIdx).clear()
    +      }
    +    }
    +  }
    +
    +  /**
    +    * Return number of records in corresponding state. Only return 0, 1, 2 because only
these
    --- End diff --
    
    This description is wrong. The method can return numbers higher than 2. Also the method
name is confusing because you don't get the exact number.


> Implement stream-stream non-window left outer join
> --------------------------------------------------
>
>                 Key: FLINK-8428
>                 URL: https://issues.apache.org/jira/browse/FLINK-8428
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>            Reporter: Hequn Cheng
>            Assignee: Hequn Cheng
>            Priority: Major
>
> Implement stream-stream non-window left outer join for sql/table-api. A simple design
doc can be foundĀ [here|https://docs.google.com/document/d/1u7bJHeEBP_hFhi8Jm4oT3FqQDOm2pJDqCtq1U1WMHDo/edit?usp=sharing]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message