flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GJL <...@git.apache.org>
Subject [GitHub] flink pull request #5933: [FLINK-9125] MiniClusterResource should set CoreOp...
Date Sun, 29 Apr 2018 19:19:38 GMT
Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5933#discussion_r184892264
  
    --- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
    @@ -149,6 +155,7 @@ public void before() throws Exception {
     
     	@Override
     	public void after() {
    +		temporaryFolder.delete();
    --- End diff --
    
    No need to call this explicitly:
    ```
        /**
         * Delete all files and folders under the temporary folder. Usually not
         * called directly, since it is automatically applied by the {@link Rule}
         */
        public void delete() {
            if (folder != null) {
                recursiveDelete(folder);
            }
        }
    ```


---

Mime
View raw message