flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From walterddr <...@git.apache.org>
Subject [GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...
Date Wed, 25 Apr 2018 16:30:36 GMT
Github user walterddr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5555#discussion_r184115873
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
    @@ -151,8 +157,36 @@ class AggregationCodeGenerator(
           }
         }
     
    -    // initialize and create data views
    -    addReusableDataViews()
    +    // get distinct filter of acc fields for each aggregate functions
    +    val distinctAccType = s"${classOf[DistinctAccumulator[_, _]].getName}"
    +
    +    val distinctAggs: Array[Seq[DataViewSpec[_]]] = isDistinctAggs.zipWithIndex.map {
    +      case (isDistinctAgg, idx) => if (isDistinctAgg) {
    +        val fieldIndex: Int = aggFields(idx)(0)
    +        val mapViewTypeInfo = new MapViewTypeInfo(
    +          physicalInputTypes(fieldIndex), BasicTypeInfo.LONG_TYPE_INFO)
    --- End diff --
    
    at this moment it will disregard any null value. But as you mention this is not correct.
Will address. 


---

Mime
View raw message