flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...
Date Thu, 19 Apr 2018 15:15:10 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5555#discussion_r182753514
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
    @@ -151,8 +157,15 @@ class AggregationCodeGenerator(
           }
         }
     
    -    // initialize and create data views
    -    addReusableDataViews()
    +    // get distinct filter of acc fields for each aggregate functions
    +    val distinctAccType = s"${classOf[DistinctAccumulator[_, _]].getName}"
    +    val isDistinctAggs = distinctAggs.map(_.nonEmpty)
    --- End diff --
    
    Instead we can create the `DataViewSpecs` here.


---

Mime
View raw message