flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #5872: [FLINK-9206][checkpoints] add job IDs to Checkpoin...
Date Wed, 18 Apr 2018 14:48:46 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5872#discussion_r182455202
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
    @@ -1214,7 +1216,7 @@ public void run() {
     				triggerCheckpoint(System.currentTimeMillis(), true);
     			}
     			catch (Exception e) {
    -				LOG.error("Exception while triggering checkpoint.", e);
    +				LOG.error("Exception while triggering checkpoint for job " + job + ".", e);
    --- End diff --
    
    I was also thinking about this but decided to keep the style of each individual message
(ok, there was no previous style here). I could change all changed lines to adhere the string
formats instead of string concatenation if you think, that's better


---

Mime
View raw message