flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #5780: [FLINK-8955][tests] Port ClassLoaderITCase to flip...
Date Sat, 14 Apr 2018 00:22:28 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5780#discussion_r181534220
  
    --- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
    @@ -49,15 +54,17 @@
      * Starts a Flink mini cluster as a resource and registers the respective
      * ExecutionEnvironment and StreamExecutionEnvironment.
      */
    -public class MiniClusterResource extends ExternalResource {
    +public class MiniClusterResource extends ExternalResource implements JobExecutor {
    --- End diff --
    
    otherwise we have to revert to using a `MiniCluster` directly, but then we lose the ยด@Rule`
benefits.


---

Mime
View raw message