From issues-return-159693-archive-asf-public=cust-asf.ponee.io@flink.apache.org Thu Mar 22 10:10:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id F3C2A18067E for ; Thu, 22 Mar 2018 10:10:04 +0100 (CET) Received: (qmail 38708 invoked by uid 500); 22 Mar 2018 09:10:04 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 38699 invoked by uid 99); 22 Mar 2018 09:10:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Mar 2018 09:10:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 886B3180D79 for ; Thu, 22 Mar 2018 09:10:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 8of27QMnKoq8 for ; Thu, 22 Mar 2018 09:10:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C1F005F5B0 for ; Thu, 22 Mar 2018 09:10:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 93327E0D6A for ; Thu, 22 Mar 2018 09:10:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4EC00214D6 for ; Thu, 22 Mar 2018 09:10:00 +0000 (UTC) Date: Thu, 22 Mar 2018 09:10:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-9047) SlotPool can fail to release slots MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409257#comment-16409257 ] ASF GitHub Bot commented on FLINK-9047: --------------------------------------- Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5739#discussion_r176347600 --- Diff: flink-runtime/src/test/resources/log4j-test.properties --- @@ -16,7 +16,7 @@ # limitations under the License. ################################################################################ -log4j.rootLogger=OFF, console +log4j.rootLogger=DEBUG, console --- End diff -- I think this should be reverted. > SlotPool can fail to release slots > ---------------------------------- > > Key: FLINK-9047 > URL: https://issues.apache.org/jira/browse/FLINK-9047 > Project: Flink > Issue Type: Bug > Components: Distributed Coordination > Affects Versions: 1.5.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Priority: Blocker > Labels: flip-6 > Fix For: 1.5.0 > > > The {{SlotPool}} releases idling slots. If the release operation fails (e.g. timeout), then it simply continues using the slot. This is problematic if the owning {{TaskExecutor}} failed before and was unregistered in the meantime from the {{SlotPool}}. As a result, the {{SlotPool}} will reuse the slot and whenever it tries to return because it is idling it will fail again. This, effectively, renders the scheduling of a job impossible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)