From issues-return-159971-archive-asf-public=cust-asf.ponee.io@flink.apache.org Fri Mar 23 11:19:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E6B7218076D for ; Fri, 23 Mar 2018 11:19:03 +0100 (CET) Received: (qmail 24733 invoked by uid 500); 23 Mar 2018 10:19:02 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 24720 invoked by uid 99); 23 Mar 2018 10:19:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Mar 2018 10:19:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8FC66182DAF for ; Fri, 23 Mar 2018 10:19:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.811 X-Spam-Level: X-Spam-Status: No, score=-109.811 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id z8_29pujLGpf for ; Fri, 23 Mar 2018 10:19:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BCB705FD9E for ; Fri, 23 Mar 2018 10:19:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 730FDE0291 for ; Fri, 23 Mar 2018 10:19:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 496A8214E8 for ; Fri, 23 Mar 2018 10:19:00 +0000 (UTC) Date: Fri, 23 Mar 2018 10:19:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-8961) Port JobRetrievalITCase to flip6 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-8961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411158#comment-16411158 ] ASF GitHub Bot commented on FLINK-8961: --------------------------------------- Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5730#discussion_r176688158 --- Diff: flink-tests/src/test/java/org/apache/flink/test/example/client/JobRetrievalITCase.java --- @@ -80,42 +95,38 @@ public void testJobRetrieval() throws Exception { final JobGraph jobGraph = new JobGraph(jobID, "testjob", imalock); - final ClusterClient client = new StandaloneClusterClient(cluster.configuration(), cluster.highAvailabilityServices(), true); - // acquire the lock to make sure that the job cannot complete until the job client // has been attached in resumingThread lock.acquire(); --- End diff -- That would no longer verify that you can connect to a _running_ job though. > Port JobRetrievalITCase to flip6 > -------------------------------- > > Key: FLINK-8961 > URL: https://issues.apache.org/jira/browse/FLINK-8961 > Project: Flink > Issue Type: Improvement > Components: Tests > Affects Versions: 1.5.0 > Reporter: Chesnay Schepler > Assignee: Chesnay Schepler > Priority: Blocker > Fix For: 1.5.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)