From issues-return-157848-archive-asf-public=cust-asf.ponee.io@flink.apache.org Mon Mar 12 11:04:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A536F180718 for ; Mon, 12 Mar 2018 11:04:04 +0100 (CET) Received: (qmail 98170 invoked by uid 500); 12 Mar 2018 10:04:03 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 98161 invoked by uid 99); 12 Mar 2018 10:04:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Mar 2018 10:04:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 34A8C1A4F40 for ; Mon, 12 Mar 2018 10:04:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id mi7aEwWi-vKt for ; Mon, 12 Mar 2018 10:04:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id EB4055FAE7 for ; Mon, 12 Mar 2018 10:04:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 28F49E030C for ; Mon, 12 Mar 2018 10:04:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8439B21474 for ; Mon, 12 Mar 2018 10:04:00 +0000 (UTC) Date: Mon, 12 Mar 2018 10:04:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-8916) Checkpointing Mode is always shown to be "At Least Once" in Web UI MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395012#comment-16395012 ] ASF GitHub Bot commented on FLINK-8916: --------------------------------------- Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5679#discussion_r173742203 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointConfigInfo.java --- @@ -143,10 +152,66 @@ public int hashCode() { } /** - * Processing mode. + * JSON serializer for {@link ProcessingMode}. */ + @JsonSerialize(using = ProcessingModeSerializer.class) + @JsonDeserialize(using = ProcessingModeDeserializer.class) public enum ProcessingMode { - AT_LEAST_ONCE, - EXACTLY_ONCE + AT_LEAST_ONCE("at_least_once"), + EXACTLY_ONCE("exactly_once"); + + private String value; + + ProcessingMode(String value) { + this.value = value; + } + + public String getValue() { + return value; + } + + public static ProcessingMode fromString(String value) { --- End diff -- these changes to the enum seem unnecessary > Checkpointing Mode is always shown to be "At Least Once" in Web UI > ------------------------------------------------------------------ > > Key: FLINK-8916 > URL: https://issues.apache.org/jira/browse/FLINK-8916 > Project: Flink > Issue Type: Bug > Components: REST > Affects Versions: 1.5.0, 1.6.0 > Reporter: Gary Yao > Assignee: vinoyang > Priority: Blocker > Labels: flip6 > Fix For: 1.5.0, 1.6.0 > > > This only happens in flip6 mode. The {{CheckpointConfigHandler}} returns the checkpoint mode uppercased. For example: > {code} > {"mode":"EXACTLY_ONCE","interval":5000,"timeout":600000,"min_pause":0,"max_concurrent":1,"externalization":{"enabled":false,"delete_on_cancellation":true}} > {code} > However, the Web UI expects the value to be lower cased: > {code} > > Checkpointing Mode > Exactly Once > At Least Once > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)