From issues-return-156836-archive-asf-public=cust-asf.ponee.io@flink.apache.org Mon Mar 5 10:43:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 98163180608 for ; Mon, 5 Mar 2018 10:43:06 +0100 (CET) Received: (qmail 28429 invoked by uid 500); 5 Mar 2018 09:43:05 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 28420 invoked by uid 99); 5 Mar 2018 09:43:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Mar 2018 09:43:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 3E2291A0A1E for ; Mon, 5 Mar 2018 09:43:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.198 X-Spam-Level: X-Spam-Status: No, score=-100.198 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URI_HEX=1.313, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id AXRbzx8uqqTo for ; Mon, 5 Mar 2018 09:43:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B71895FBC5 for ; Mon, 5 Mar 2018 09:43:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 801BAE0373 for ; Mon, 5 Mar 2018 09:43:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9520F2126E for ; Mon, 5 Mar 2018 09:43:00 +0000 (UTC) Date: Mon, 5 Mar 2018 09:43:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-5479) Per-partition watermarks in FlinkKafkaConsumer should consider idle partitions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385863#comment-16385863 ] ASF GitHub Bot commented on FLINK-5479: --------------------------------------- GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/5634 [FLINK-5479] [kafka] Idleness detection for periodic per-partition watermarks in FlinkKafkaConsumer ## What is the purpose of the change This commit adds the capability to detect idle partitions in the `FlinkKafkaConsumer` when using periodic per-partition watermark generation. Users set the partition idle timeout using `setPartitionIdleTimeout(long)`. The value of the timeout determines how long a an idle partition may block watermark advancement downstream. ## Brief change log - Adds a `setPartitionIdleTimeout(long)` configuration method - Modifies `KafkaTopicPartitionStateWithPeriodicWatermarks` to keep track of necessary information to determine partition idleness. - Adds idleness detection logic to `AsbtractFetcher.PeriodicWatermarkEmitter`. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (**yes** / no) - If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented) You can merge this pull request into a Git repository by running: $ git pull https://github.com/tzulitai/flink FLINK-5479 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5634.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5634 ---- commit d7b95ca1c8bb85f77dd6b83becf8fc1d5cccb810 Author: Tzu-Li (Gordon) Tai Date: 2018-03-05T09:35:02Z [FLINK-5479] [kafka] Idleness detection for periodic per-partition watermarks This commit adds the capability to detect idle partitions in the FlinkKafkaConsumer when using periodic per-partition watermark generation. Users set the partition idle timeout using `setPartitionIdleTimeout(long)`. The value of the timeout determines how long a an idle partition may block watermark advancement downstream. ---- > Per-partition watermarks in FlinkKafkaConsumer should consider idle partitions > ------------------------------------------------------------------------------ > > Key: FLINK-5479 > URL: https://issues.apache.org/jira/browse/FLINK-5479 > Project: Flink > Issue Type: Improvement > Components: Kafka Connector > Reporter: Tzu-Li (Gordon) Tai > Priority: Blocker > Fix For: 1.5.0 > > > Reported in ML: http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Kafka-topic-partition-skewness-causes-watermark-not-being-emitted-td11008.html > Similar to what's happening to idle sources blocking watermark progression in downstream operators (see FLINK-5017), the per-partition watermark mechanism in {{FlinkKafkaConsumer}} is also being blocked of progressing watermarks when a partition is idle. The watermark of idle partitions is always {{Long.MIN_VALUE}}, therefore the overall min watermark across all partitions of a consumer subtask will never proceed. > It's normally not a common case to have Kafka partitions not producing any data, but it'll probably be good to handle this as well. I think we should have a localized solution similar to FLINK-5017 for the per-partition watermarks in {{AbstractFetcher}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)